1. New Colony Rule behaves oddly

• When I activate the law after colonization is complete: no bonus
• When I activate the law before the colonization is complete and turn it off right after the completion (non-Republic): bonus kept (+25 Approval)
• When I activate the law before the colonization is complete (Republic): bonus initiated (+35 Approval)
• When I turn it off right after the case above: bonus reduced (+25 Approval)

I can understand the second case. It might be the intention of design. But the 4th case just seems to be a bug.

What I did on this matter

- Industrialist Law
* Player can now get bonus from colonies completed before the law was enacted, if the bonus period is yet to be terminated
* New Colony Rule effect will disappear as soon as you repeal the law

I set BaseValue of approval bonus at TemporaryEffectColonyHappinessBoost (ClassColonizedSystem) to zero. Then sent the +25 & +35 Approval part to the law entierly.

Plus to that, I made the tempeffect activated when industrialists are in mainstream party, so that you can immediately get the bonus even if you were late.

2. Colonization without proper tech penalty only applied when ecologists forced law is in effect

As you can read, currently there is no penalty for lacking colonization tech if ecologist forced law is not in effect.

What I did on this matter

 * Planet without proper colonization technology will have zero FIDSI on planet

<Modifier TargetProperty="PlanetInitialFIDSPenalty" Operation="Addition" Value="-1" Path="ClassEmpire/ClassColonizedStarSystem/ClassColonizedPlanet" Priority="-10" TooltipHidden="true"/><!--[ES2GALLMOD][0830EcoForcedLawFix]-->

I added this on EmpireTypeMajor to remove the planetary FIDS when there is no proper colonization tech only for major empires. From my test it didn't removed FIDS from minors or mining probes.

You can see those changes in my mod https://steamcommunity.com/sharedfiles/filedetails/?id=1744546179