Nakalim relics duplication during combat calculation in long distance online game.

1. Bug summary / Thread Title

2. Bug description

Hello, I'm playing an online game with 5 players between France, US, and Norway. I'm not sure what the usual combat calculation time is for online matches, but once we get far enough into the game, the combat calculation can take a very long time (30 seconds - 1 minute is common). I think it is expected when playing from such far distances, with some of us having slow network connection, and with how intensive the combat simulation may be.

During this calculation time, all players cannot perform actions that require a response from the server, such as: accepting a quest, moving troops, or adding a building to construction queue. Usually when you try to do this, you can easily click many times without confirmation from the server. And none of these events are processed until after the combat calculation ends.

I understand this is a result of how the engine works with the networking. But there is a specific case where this lead to an issue: Playing Nakalim, and assigning/unassigning relics to a hero during this "combat calculation" time. During this time if I am struggling to get a response from the server, I will naturally try many times to click on "Accept" over and over again if I'm either trying to assign or unassign relics from my hero.

Once the combat calculating is over, this relic transfer will get accepted by the server. Except the same transfer will get confirmed by the server many times in a row. This can lead to extra relics assigned to the hero than intended with no possible purpose, which cannot be reassigned. It can also lead to pulling extra relics out of thin air.

This leads to 2 possible issues.

1) Relics are stuck on heros, even though the buff is not being applied, and cannot be unassigned (they are useless and not increasing science production). Many, many relics can get stuck this way.

2) At first it removes the amount from your unassigned relics, but if it runs out then it will add them out of thin air. This leads to having many more relics than you should. At turn 191 in the game, I should only have about 40 relics total. But due to this duplication bug, I have 120 relics. This is a problem in our game because it's making my ships way too strong, especially noticable in the Juggernaut. With Hero relics skill active, it's inflating its stats to insanely high amounts, since the calulation includes these duplicated relics in the total sum of all relics (I think).

3. Steps to reproduce

1) Play an online game as Nakalim.

2) Initiate a combat that takes a very long time to compute (30 seconds - 1 minute)

2a) During this time, try to add/remove all the Relic Skills assigned to a hero. Click on the Accept button several times while it lags.

3) When battle is done computing, relics will be misplaced.

4. Reproducibility

5/5 - Consistent

Assuming the combat lag happens, this error should occur consistently. I think it would not occur if combat lag was minimal. And it will not occur when trying to manage Hero relic skills during other points in time. It happened in 2 separate instances during normal online gameplay.

5. Expected behavior

Relics should not duplicate.
Relics should not become attached to heroes in a way that makes them immutable.
During combat computing, spammed requests to modify relics should not be accepted more than once.

6. Version

V1.5.11 S5-Gold Public.

7. Notes

When the Hero Relic skill is applied, I expect damage and health to increase. The expected increase is +5% Health and +5% damage for 40 relics. Due to the duplicated relics, I believe it is counting this bonus for all 120 relics. In the screenshots below I compare the difference by using a Juggernaut as reference.

Also since all my relics, both duplicated relics and the ones I cannot unassign from hero, are stuck. My science output is crippled for the rest of the game. I have no relics assigned to generate science now, and it's impossible to get them back.

Thank you for taking a moment to read through this. I know this seems like a very technical issue, and a lot of it is based on my own assumptions about how the game engine works. Let me know if there's any further data I can provide, and anything I can explain better.

8. Attachments /!\

Screenshots

The Juggernaut is the unit this became most noticable on. So I'm using it for reference. First, the Juggernauts original stats, when my hero has NO relic skills applied.