Hi Xeryx,

I did notice some rounding issues in the overall offense power calculation.  For example,  a tier 1 kinetic has 5,6,6 power and thus 17 offence power,  but it is displayed as 16.   Looking at the XML I think I know why;   it seems instead of adding 5+6+6 it adds the effectiveness then multiplies by the weapon dps,  so we get (1+1+0.8)*6 = 16.8 which is rounded down to 16.    Such small rounding errors might look odd but,  I'm fairly sure they have almost no effect on gameplay.  :)

Thanks for your reports!

For the Vodyani leader, the fix will be deployed soon.

For the kinetic weapon values, I asked a programmer to check it.

bump for dev love!   

Any chance to fix/track the XML bug in SimulationDescriptions[ModuleWeapon].xml ?

Ditto for the Vodyanoi leader going to be lighting up odd areas of the screen?

Both of these are cosmetic/display bugs only,  but it would be nice to see at least a "yes we've put it into the database".

Thanks guys!

No response from devs yet? hmm

Here is a visual bug for the Vodyani Leader. For some reason, the Body glow is showing by the leader's hand.

Amplimath,  did you also get the XML changes required to fix the detalied weapon damage display to the devs?   It's an easy fix and only cosmetic but it would be nice to see in a patch.

Thanks!

Silas

Xeryx wrote:

Hello Weaponizedcaffeined! hehe

I have a very strange one here for you:

Planet Pisces:

Will not display any normal improvements to produce and It was just colonized. I have never seen this issue before in all gameplay, and never at Pisces. It is a bummer because it is an outstanding system.  I have no idea what the Global thing is in the production choice window but it is probably what is causing the issue. It has to be just this specific planet because I have not seen any issues with any others. Maybe some others can confirm this issue with Pisces

Here is the Saves b4 and after

1.0.18 Lockarian Bug b4 Pisces.zip

1.0.18 Lockarian Bug at Pisces2.zip

Here is the Log

Diagnostics - 2017'06'21 @1701'05''.zip

Here is a screenshot

Hi there,

I have reproduced the Pisces bug and assigned it to a programmer.

Thanks for your report!

Cheers

Well done SilasofBorg and with some of my testing I also concluded the the damage is correct. 

My biggest concern is the placement of ships in the wrong flotilla's

The incorrect damage numbers are limited to the design screen.

As a test,  I edited the XML the give kinetic 1 weapons 200 flak damage across the board.    I then designed a scout with no defense and 2 kinetic 1 weapons which together registered over 400 damage at all ranges according to the detailed breakdown.   Overall ship power was calculated correctly at 33.

I then engaged this scout at Long, Medium, and Short ranges against a Horatio scout armed with a single laser and no defenses.  

In all cases I did exactly twice as much damage as the Horatio scout,  completely expected since I had two tier 1 weapons to the Horatio's one.   Had the flak actually been mis-applied as weapon damage the Horatio scout would have been anihilated in short order and my battles would not have all ended in draws.

Now,  it is still possible that the weapon effectiveness calculations (percentages) are used in other flotilla assignment / card choice AI,  so fixing the bug is probably still a really good idea.   It just doesn't appear to have any actual effect on straight-up damage,  which is a relief.

Also Xeryx,  if I understand your other question,  the efficiency percentages indicate how much of your total loadout you can bring to bear at any given range.   So if you have one long range weapon of 50 power (100/0/0) and one short range weapon of 50 power (0/0/100),  your range effectiveness will be 50% / 0 / 50%.

This should actually be pretty easy to test.   I'll create a game in the recently published 1.019,  make a ship with kinetics,  and throw it against the first non-kinetic (ie not bugged) pirate I meet with and without the fixes to the XML at various ranges.   My lunch break is nearly done but I should be able to test it this evening.

Did some futzing around with the XML and fixed it.

It remains up to the devs to figure out whether or not this is just a display bug,  but I was able to fix the display by adding "Path="ClassModuleWeapon,!ClassModuleWeaponFlack" in SimulationDescriptions[ModuleWeapon].xml (changes in bold):

        <BinaryModifier TargetProperty="DamagePerSecondShort"    Operation="Addition"       Left="1"    BinaryOperation="Subtraction"  Right="$(ShortRangePenalty)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack"/>
        <Modifier TargetProperty="DamagePerSecondShort"          Operation="Multiplication" Value="$(DamagePerSecond)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack"/>
        <Modifier TargetProperty="DamagePerSecondShort"          Operation="Addition"       Value="$(DamagePerSecondShort)"  Path="../ClassShip"/>

        <BinaryModifier TargetProperty="DamagePerSecondMedium"   Operation="Addition"       Left="1"    BinaryOperation="Subtraction"  Right="$(MediumRangePenalty)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack"/>
        <Modifier TargetProperty="DamagePerSecondMedium"         Operation="Multiplication" Value="$(DamagePerSecond)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack"/>
        <Modifier TargetProperty="DamagePerSecondMedium"         Operation="Addition"       Value="$(DamagePerSecondMedium)"  Path="../ClassShip"/>

        <BinaryModifier TargetProperty="DamagePerSecondLong"     Operation="Addition"       Left="1"    BinaryOperation="Subtraction"  Right="$(LongRangePenalty)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack"/>
        <Modifier TargetProperty="DamagePerSecondLong"           Operation="Multiplication" Value="$(DamagePerSecond)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack"/>
        <Modifier TargetProperty="DamagePerSecondLong"           Operation="Addition"       Value="$(DamagePerSecondLong)"  Path="../ClassShip"/>

Enjoy!

Well, I kind of know why this is happening.

I looked at the xml in SimluationDescriptors[ModuleWeapon] and ModuleDefinition[Weapons] and it is pretty clear that the projectile weapons' "slave" weapon (used to model flack damage) is getting added in at some point,  possibly only for the design screen but it might be good for the devs to check other places too.

For example,  Kinetic1 has:

        <SlaveModule Name="ModuleWeaponFlack1" CategoryForSimulationDescriptors="CategoryWeaponFlack"/>

This "Flack1" weapon is partially defined as follows:

        <Modifier TargetProperty="LongRangePenalty"             Operation="Addition" Value="1"         Path="ClassModuleWeapon" TooltipHidden="true"/>
        <Modifier TargetProperty="MediumRangePenalty"           Operation="Addition" Value="0"         Path="ClassModuleWeapon" TooltipHidden="true"/>
        <Modifier TargetProperty="ShortRangePenalty"            Operation="Addition" Value="0"         Path="ClassModuleWeapon" TooltipHidden="true"/>

Flack1 has a "hidden" damage of 20,  which is getting incorrectly added to the displayed damage.

Note that other places in the XML exclude flack from calculations,  for example:

<!-- Used to set the offensive power of the module -->
        <BinaryModifier TargetProperty="OffensiveMilitaryPower"  Operation="Addition"       Left="1"    BinaryOperation="Subtraction" Right="$(LongRangePenalty)"    Path="ClassModuleWeapon,!ClassModuleWeaponFlack" TooltipHidden="true"/>
        <BinaryModifier TargetProperty="OffensiveMilitaryPower"  Operation="Addition"       Left="1"    BinaryOperation="Subtraction" Right="$(MediumRangePenalty)" Path="ClassModuleWeapon,!ClassModuleWeaponFlack" TooltipHidden="true"/>
        <BinaryModifier TargetProperty="OffensiveMilitaryPower"  Operation="Addition"       Left="1"    BinaryOperation="Subtraction" Right="$(ShortRangePenalty)"  Path="ClassModuleWeapon,!ClassModuleWeaponFlack" TooltipHidden="true"/>
       
So I think it might just be a display thing.

That's a fair point, I don't really pay attention much to enemy tactics unless I'm on the losing end. 

I don't think battles are deterministic are they? The actual fight is simulated was my expectation. 

I am sure they use those numbers to calculate the percentages, for what range the ship is good at, it is common sense.  Otherwise, why would they have them calculated?